Add get_script_instance to GDExtension
#80040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comments fixed and clang-format run. Sorry, I'm very used to it running automatically and forgot to set it up. |
fuzzybinary
added a commit
to fuzzybinary/godot_dart
that referenced
this pull request
Jul 30, 2023
Casting to script types requires [this PR](godotengine/godot#80040), which will make this extension require Godot 4.2 when it is merged.
dsnopek
approved these changes
Aug 7, 2023
fuzzybinary
force-pushed
the
add-object-get-script-instance
branch
from
27592bc to
9ee4825
Compare
|
Rebased and pushed! |
|
Thanks! Unfortunately, you're also going to need to squash this into a single commit per Godot's Git workflow: https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#the-interactive-rebase Sorry I didn't catch that when I was reviewing earlier |
Adds a method to GDExtension to get the ScriptInstanceExtension for an object.
fuzzybinary
force-pushed
the
add-object-get-script-instance
branch
from
9ee4825 to
efc8fd6
Compare
|
Fixed 😅 |
akien-mga
changed the title
get_script_instance to GDExtension
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method to GDExtension to get the ScriptInstanceExtension for an object.
This implements the proposal in godotengine/godot-proposals#7199
get_script_instance()to GDExtension godot-proposals#7199