Add is_conformal method to Basis and Transform2D
#79523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlupugla
reviewed
Jul 15, 2023
nlupugla
reviewed
Jul 15, 2023
aaronfranke
force-pushed
the
is-conformal
branch
from
9ee0f11 to
4625cad
Compare
aaronfranke
force-pushed
the
is-conformal
branch
2 times, most recently
from
09681ac to
d85f55b
Compare
aaronfranke
force-pushed
the
is-conformal
branch
2 times, most recently
from
1ae6529 to
38c7639
Compare
|
Updated the PR to have an optimized 3D implementation suggested by @SlugFiller. |
aaronfranke
force-pushed
the
is-conformal
branch
from
38c7639 to
96a959a
Compare
aaronfranke
force-pushed
the
is-conformal
branch
from
5008605 to
1fb56a4
Compare
RevoluPowered
requested changes
Sep 13, 2023
aaronfranke
force-pushed
the
is-conformal
branch
from
1fb56a4 to
56806ff
Compare
RevoluPowered
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
LGTM - probably @akien-mga should give it a check for merge
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
is_conformalto Basis and Transform2D.This method returns true if the basis is conformal, meaning it preserves angles and distance ratios, and may only composed of rotation or uniform scale. Returns false if the basis has non-uniform scale or shear/skew.
This can be used to validate if the basis is non-distorted, which is important for physics and other use cases. I have wanted a method like this for a long time but I did not know what to call it before now.
This PR also includes documentation and test cases. Most of the added lines are test cases.
I plan to use this method in the engine in #79364, but I wanted to open this PR to add the method first.