-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Improve signal callback generation #79366
Editor: Improve signal callback generation #79366
Conversation
7798c03
to
ba98907
Compare
ba98907
to
bbd5606
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bbd5606
to
b6e9be1
Compare
b6e9be1
to
129f404
Compare
129f404
to
e37e03b
Compare
get_script_signal_list()
e37e03b
to
4b5daf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C# changes look good to me. Should likely be reviewed by the Editor team as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an improvement, and a bugfix too. There are probably still cases which aren't handled perfectly, but they are certainly not handled worse than before.
Thanks! |
Note: Some changes have been extracted to #80745, #80765 and #81079.
Added support for typed arrays, enums and
Variant
.