Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-picks for the 4.1 branch (future 4.1.1) - 1st batch #79297

Merged
merged 77 commits into from
Jul 11, 2023
Merged

Cherry-picks for the 4.1 branch (future 4.1.1) - 1st batch #79297

merged 77 commits into from
Jul 11, 2023

Conversation

YuriSizov
Copy link
Contributor

Not including changelog for now.

Daylily-Zeleen and others added 30 commits July 10, 2023 17:11
@Daylily-Zeleen @YuriSizov
Fixed the fallback logic of OS::shell_show_in_file_manager
71d5827 
(cherry picked from commit 9dd9818)
@Sauermann @YuriSizov
Revert "Fix focusloss of non-exclusive AcceptDialog with `close_on_…
0ec5994 
…escape`"

This reverts commit 7f547fc.

(cherry picked from commit bfa7497)
@clayjohn @YuriSizov
Initialize particles instance buffer in case it is used before being …
bc9bc23 
…updated

(cherry picked from commit 35ed7c7)
@Chaosus @YuriSizov
Fix using uint suffix at the hex number declaration in shaders
6255a64 
(cherry picked from commit 1994c25)
@akien-mga @YuriSizov
Linux: Allow unbundling brotli to use system library
da1e511 
(cherry picked from commit 153c4a4)
@BastiaanOlij @YuriSizov
Take eye offset into account for depth in StandardMaterial3D
89e64da 
(cherry picked from commit 581d081)
@RedworkDE @YuriSizov
Fix export options of scripted EditorExportPlugins
03e82be 
(cherry picked from commit fa84d09)
@Amir-Rasteg @YuriSizov
Fix a typo in the String.to_float description
7a8ac69 
(cherry picked from commit 9744657)
@zorbathut @YuriSizov
Fix: Incorrect property names in FontFile::_get_property_list().
371b31c 
(cherry picked from commit 7ee916a)
@timothyqiu @YuriSizov
Fix error when non-ASCII characters in resource pack path
a8bfdd8 
(cherry picked from commit df5c68a)
@timothyqiu @YuriSizov
Translate "No match" message in FindReplaceBar
545e37c 
(cherry picked from commit ac454ce)
@nklbdev @YuriSizov
Fix wrong type casting for octahedral tangents
92040e8 
(cherry picked from commit c022f52)
@nklbdev @YuriSizov
Potencially fix nan's on octahedral tangents in RenderingServer
2bfeb29 
(cherry picked from commit 1d16704)
@raulsntos @YuriSizov
C#: Compare symbol names without null flow state
8010522 
(cherry picked from commit 671a5b4)
@Rindbee @YuriSizov
Make sure the shortcut key respects the context in `TileSetAtlasSourc…
836913c 
…eEditor`

(cherry picked from commit fec731b)
@KoBeWi @YuriSizov
Fix dropping files from res:// to res://
705c1d6 
(cherry picked from commit 1d970cd)
@anvilfolk @YuriSizov
Fix regression with enum descriptions now showing up in documentation.
a0366f1 
(cherry picked from commit d48636c)
@bitsawer @YuriSizov
Fix shader language float literal precision truncation
0dec3d6 
(cherry picked from commit 356297f)
@bitsawer @YuriSizov
Make shader preprocessor keyword colors consistent
f5addd5 
(cherry picked from commit a5d6152)
@TokageItLab @YuriSizov
Fix infinity loop state can't break
ed9c091 
(cherry picked from commit fc40ba2)
@theraot @YuriSizov
Do not change a node unique name to the same name
8cea540 
(cherry picked from commit b2bef8c)
@mb4c @YuriSizov
Add tooltip description wrapping in scene tree and plugin settings
6018ff4 
(cherry picked from commit d007be2)
@RedworkDE @YuriSizov
C#: Add null check before calling UnregisterGodotObject
69948f7 
(cherry picked from commit 693e6e0)
@Sauermann @YuriSizov
Fix that _drop_physics_mouseover only happens when necessary
4e84660 
Previously the call was executed every time, because in the
`_drop_mouse_over();` a few lines above, `gui.mouse_over = nullptr;`
was set.

(cherry picked from commit 37a96d3)
@bruvzg @YuriSizov
[Windows] Flash both the window caption and taskbar button on `reques…
221535c 
…t_attention`.

(cherry picked from commit 49af258)
@bcmpinc @YuriSizov
Fix Camera3D project_* methods not accounting for frustum offset
3fd5fec 
This does not fix Camera3D::project_ray_normal().
Adds Camera3D::get_camera_projection() and exposes it to GDScript

(cherry picked from commit 47e63bc)
@KoBeWi @YuriSizov
Focus current node after connecting
ffc87b2 
(cherry picked from commit d17c522)
@aaronfranke @YuriSizov
Sort project tags before saving
4cec4bd 
(cherry picked from commit d667402)
@MewPurPur @YuriSizov
Fix enum tooltip with no description
ab14aa9 
(cherry picked from commit c0453a5)
@MewPurPur @YuriSizov
Improve string printing in the tiledata editor
8cefce5 
(cherry picked from commit 1649dca)
@YuriSizov YuriSizov requested review from a team as code owners July 10, 2023 16:16
akien-mga
akien-mga approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Pre-emptively approving, though I'm aware Yuri will add a couple cherry-picks from PRs merged today (also approved by me).

timothyqiu and others added 6 commits July 11, 2023 12:21
@timothyqiu @YuriSizov
Clarify EditorExportPlugin::add_file only remaps in _export_file
167b02d 
(cherry picked from commit df1d354)
@AThousandShips @YuriSizov
Improve error message for Node.set_owner
1e2bfdc 
(cherry picked from commit 0183340)
@aaronfranke @YuriSizov
Improve text in popup warning, remove "upgrade or downgrade" text
e3cfc02 
(cherry picked from commit 95ccbde)
@akien-mga @YuriSizov
Linux: Fix build with use_sowrap=no and various warnings/errors
6ec2d6d 
(cherry picked from commit dcd16a5)
@akien-mga @YuriSizov
Fix Linux move_to_trash wrongly reporting files as not found
30ab0e2 
We can't rely on the error code from `gio` or `kioclient5`, in my
rudimentary testing they return `1` for both missing files and other
situations like not having a Trash can on the mounted volume.

Fixes godotengine#79108.

(cherry picked from commit a6e75f3)
@kleonc @YuriSizov
Hide/show AcceptDialog's button spacer on button visibility changed
2796b62 
(cherry picked from commit 30a9c90)
akien-mga
akien-mga approved these changes Jul 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
RedworkDE
RedworkDE reviewed Jul 11, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@YuriSizov YuriSizov merged commit e709ad4 into godotengine:4.1 Jul 11, 2023
@YuriSizov YuriSizov deleted the 4.1-cherrypicks branch July 11, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedworkDE RedworkDE RedworkDE left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug enhancement topic:core topic:editor
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.