Add --no-header option

[abitrolly]

The option to suppress printing Godot headers, see godotengine/godot-proposals#4998 for details.

Closes godotengine/godot-proposals#4998.
Closes #63575.

[ghost]

To add this feature to the project settings, I suggest you add the following lines of code:

in core/config/project_settings.cpp to line 1200:

GLOBAL_DEF("application/run/quit_header", false); 

and in main.cpp to line 1600 :

if (bool(GLOBAL_GET("application/run/quit_header"))){
		Engine::singleton->_print_header = false;
}

that's about it!

[Calinou]

GLOBAL_DEF("application/run/quit_header", false); 

Why is the setting called quit_header instead of print_header? Is that a typo?

[ghost]

yes, it's a mistake on my part, we can name it "disable header"

[ghost]

I'll test it and let you know if it works when I've finished running my workflow.

[ghost]

I tested it with the project parameters and it worked!

the name "quiet_header" is Temporary

[abitrolly]

@kaissouDev I'd prefer to see this PR reviewed/merged first, and then address project setting logic in a different PR. To keep it simple.

[ghost]

Yes, you're right, it's better to wait until this pull request is merged. At least we know how to add this option to the project parameters.

[abitrolly]

Rebased, solved conflicts. Testing with the hello script.

$ /bin/godot.linuxbsd.editor.x86_64 -s hello.gd
Godot Engine v4.3.dev.custom_build.7bfed92d9 - https://godotengine.org
Inconsistent value (1) for DRI_PRIME. Should be < 1 (GPU devices count). Using: 0
OpenGL API 4.6 (Core Profile) Mesa 23.3.5 - Compatibility - Using Device: Intel - Mesa Intel(R) HD Graphics 4400 (HSW GT2)
 
Hello!
Project is missing: /tmp/ggg/project.godot 

$ ./bin/godot.linuxbsd.editor.x86_64 -s hello.gd --no-header
Inconsistent value (1) for DRI_PRIME. Should be < 1 (GPU devices count). Using: 0
Hello!
Project is missing: /tmp/ggg/project.godot

I will now try to add this to projects settings too.

[abitrolly]

This is now ready for review.

@Calinou @kaissouDev

[Mickeon]

Docs do look good now. Remember to squash your commits now. Thank you for your patience very much

[abitrolly]

Squashed into a single commit.

[abitrolly]

@AThousandShips what is the p_string convention for function argument? I just followed the style, but it is still interesting what p_ stands for.

[AThousandShips]

"parameter" :)

[Calinou]

Tested locally, it works as expected. Should be good to merge after applying the suggestion and squashing commits together.

[abitrolly]

@Calinou the rendering method info strings are gone from Vulkan backend after rebasing over #87340 but that can be added later if needed. So this is now ready.

[Calinou]

@Calinou the rendering method info strings are gone from Vulkan backend after rebasing over #87340 but that can be added later if needed. So this is now ready.

I noticed this while testing – the OpenGL header is silenced, but not the Vulkan header. Could you look into resolving this so it's silenced with both rendering drivers?

[abitrolly]

@Calinou can you give me the message? I don't know what to look for..

[Calinou]

@Calinou can you give me the message? I don't know what to look for..

The message is here:

godot/servers/rendering/rendering_device.cpp

Line 4986 in 907db8e

print_line(vformat("%s %s - %s - Using Device #%d: %s - %s", get_device_api_name(), get_device_api_version(), rendering_method, device_index, _get_device_vendor_name(device), device.name));

[abitrolly]

@Calinou done.

[akien-mga]

Looks good to me. Last few nitpicks :)

I noticed that @AThousandShips is credited as co-author twice in your commit message, you could amend it to remove the duplicate line. (Not critical though, but this could be done while doing the other suggested changes.)

[abitrolly]

@akien-mga done.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[ghost]

Good job @abitrolly !