Mark NavigationServer3D.region_bake_navigation_mesh() as deprecated #79137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marks NavigationServer3D.region_bake_navigation_mesh() as deprecated.
smix8
force-pushed
the
region_bake_depr_4.x
branch
from
34d0627 to
f7ebce2
Compare
akien-mga
approved these changes
Jul 7, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks
NavigationServer3D.region_bake_navigation_mesh()as deprecated.This function is marked deprecated because it will be removed together with the
NavigationMeshGeneratorsingleton at some point. There is no future for both as discussed multiple times in dev chat. So much wrong with this function other than the mentioned threading changes in the warnings.It was added and exists because of init chain problems with the NavigationMeshGenerator singleton. Instead of fixing the init chain problems this dummy function was added as a "fix".
All this function ever did was reroute everything to the real functions to parse and bake navigation meshes while labeling itself as a region function without having anything to do with a region. The function does not even have a region RID parameter.