Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SVG icons and remove unused Transpose icon #79062

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented Jul 5, 2023

Moar! The icons folder is now less than 100π kilobytes, reducing the executable size by 10 kB. A few icons were tweaked, having their small artifacts and imprecision fixed up. Most importantly the CPUParticles gizmo, which wasn't synced with how I recently simplified the overly detailed icon, was tweaked.

The transpose icon used to show up in the 3.x tilemap editor, now it's unused. I think the icon was so unclear that if we need something like it again, we might as well re-do it.

@MewPurPur MewPurPur requested a review from a team as a code owner July 5, 2023 13:40
@Calinou Calinou added this to the 4.x milestone Jul 5, 2023
@capnm
Copy link
Contributor

capnm commented Jul 5, 2023

@MewPurPur I can't believe it, on the tip d28f9af it's complaining during a clean startup with only 3 tiny details. Fixing that could make it yet smaller and faster :)

This seems to be coming from the platform/macos/export/run_icon.svg
[L] SVG (thirdparty/thorvg/src/loaders/svg/tvgXmlParser.cpp 523): 
Unsupported attributes used [Elements type: Path][Id : NO_ID][Attribute: -inkscape-stroke][Value: none]

[L] GD (./editor/editor_themes.cpp:249) editor_generate_icon: 
	--> Loading icon[157] CopyNodePath.svg
[L] SVG (thirdparty/thorvg/src/loaders/svg/tvgSvgLoader.cpp 3213): 
Inefficient elements used [Size is zero][Node Type : Circle]

[L] GD (./editor/editor_themes.cpp:249) editor_generate_icon: 
	--> Loading icon[314] GuiSpinboxUpdownDisabled.svg
[L] SVG (thirdparty/thorvg/src/loaders/svg/tvgXmlParser.cpp 363): 
Unsupported attributes used [Elements type: Svg][Id : NO_ID][Attribute: enable-background][Value: new 0 0 16 16]

@MewPurPur
Copy link
Contributor Author

Okay! Fixed all three.

@MewPurPur MewPurPur force-pushed the svg-optimizations branch from 75ea6e2 to 979864d Compare July 5, 2023 17:07
@MewPurPur MewPurPur requested review from a team as code owners July 5, 2023 17:07
@MewPurPur MewPurPur force-pushed the svg-optimizations branch 4 times, most recently from 4d85ef1 to 5e54cb4 Compare July 6, 2023 09:36
@MewPurPur MewPurPur force-pushed the svg-optimizations branch from 5e54cb4 to fe194f8 Compare July 7, 2023 14:58
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Jul 7, 2023
@YuriSizov YuriSizov merged commit 1da09fd into godotengine:master Jul 12, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@MewPurPur MewPurPur deleted the svg-optimizations branch July 12, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants