Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for the node (physics) processing and process priority #78156

Merged

Conversation

Maran23
Copy link
Contributor

@Maran23 Maran23 commented Jun 12, 2023

This PR adds a set of tests for node which checks node (physics) processing and process priority. This also includes the internal processing.

After the process priority regression which was fixed in #78044 I thought it may be a good idea to have tests for that area.
Reverting #78044 also makes those tests fail.

@Maran23 Maran23 requested a review from a team as a code owner June 12, 2023 21:09
@Maran23 Maran23 force-pushed the node-tests-processing-priority branch from 741544d to 993d48c Compare June 12, 2023 21:14
@akien-mga
Copy link
Member

There are some indentation issues: https://github.com/godotengine/godot/actions/runs/5248614076/jobs/9480335402?pr=78156

@Maran23 Maran23 force-pushed the node-tests-processing-priority branch 3 times, most recently from da18fb5 to 599de77 Compare June 12, 2023 21:52
@Maran23 Maran23 force-pushed the node-tests-processing-priority branch from 599de77 to 60a17ba Compare June 12, 2023 22:21
@Maran23
Copy link
Contributor Author

Maran23 commented Jun 12, 2023

There are some indentation issues: https://github.com/godotengine/godot/actions/runs/5248614076/jobs/9480335402?pr=78156

Should be fixed now. I found out that the .editorconfig was not correctly used, sorry!
I also forgot to make a default nullptr assignment and was wondering why the null check wasn't working.
Probably related xkcd: https://xkcd.com/371/ 😄
Note: For some reason the Windows / Template build always gets cancelled immediately.

@akien-mga akien-mga merged commit ae896bb into godotengine:master Jun 13, 2023
@akien-mga
Copy link
Member

Thanks!

@Maran23 Maran23 deleted the node-tests-processing-priority branch August 4, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants