Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Add [Obsolete] attribute to deprecated members #77904

Merged

Conversation

raulsntos
Copy link
Member

This uses the boolean in DocData to determine if a member is deprecated since this information doesn't seem to be available in ClassDB. Unfortunately, since it's only a boolean we can't add a deprecation message.

There is existing code in the C# binding generator for deprecating members. These fields have never been used, they were never populated. I think these fields were meant to be populated with deprecation information coming from ClassDB. I have left this code untouched but should probably be removed.

@raulsntos raulsntos added this to the 4.x milestone Jun 6, 2023
@raulsntos raulsntos requested a review from a team as a code owner June 6, 2023 10:40
@akien-mga akien-mga modified the milestones: 4.x, 4.1 Jun 6, 2023
@akien-mga akien-mga merged commit 0a0132c into godotengine:master Jun 6, 2023
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/obsolete-deprecated-members branch June 6, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants