Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extraction of chained tr() calls #77538

Merged
merged 1 commit into from
May 27, 2023
Merged

Fix extraction of chained tr() calls #77538

merged 1 commit into from
May 27, 2023

Conversation

timothyqiu
Copy link
Member

Fix #77529

Only the last part of a chained call was examined, thus the issue.

@timothyqiu timothyqiu added this to the 4.1 milestone May 27, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner May 27, 2023 02:42
@YuriSizov YuriSizov merged commit cbf4abf into godotengine:master May 27, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@timothyqiu timothyqiu deleted the chained branch May 27, 2023 15:22
@Destructor17 Destructor17 mentioned this pull request Jun 18, 2023
Closed
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:gdscript
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Generate POT from GDScript does not include tr("...").format({...})
3 participants
@timothyqiu @YuriSizov @akien-mga