Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression Evaluater (REPL support with inspector sequential results) #76736

Closed
wants to merge 1 commit into from

Conversation

LinqLover
Copy link

@LinqLover LinqLover commented May 4, 2023

Note
This is a re-make of #60134 by @rohanrhu (see #60134 (comment)). I have no idea what I'm doing, I just ran git rebase. I did not compile or try anything out. All glory and expertise go to the original author.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual Script support was removed in 4.0.

@MewPurPur
Copy link
Contributor

MewPurPur commented May 4, 2023

The old issue and its proposal aren't well-written and don't explain anything, although, they have a lot of support... I still don't really get what this is though. Could someone explain?

@fire fire changed the title Expression Evaluater (REPL support with inspector sequent results) Expression Evaluater (REPL support with inspector sequential results) May 6, 2023
@LinqLover
Copy link
Author

The old issue and its proposal aren't well-written and don't explain anything, although, they have a lot of support... I still don't really get what this is though. Could someone explain?

Well, in a nutshell, it should enable users to evaluate custom queries during debugging, and all evaluation results are displayed in a list. This is a common feature to many delivery, it improves interactivity and explorability, it would be great to see this in Godot, too.

@rohanrhu
Copy link
Contributor

Dooooon't wooorry I'm back to the Godot Universe. I'll take care of all of my PRs sooon.

@Calinou
Copy link
Member

Calinou commented Jun 1, 2023

I get the following error when building this PR rebased against the latest master branch:

editor\debugger\script_editor_debugger.cpp(41): fatal error C1083: 
Cannot open include : 'editor/debugger/editor_network_profiler.h' : No such file or directory

Changing the path in that file to modules\multiplayer\editor\editor_network_profiler.cpp resolvess the issue, but to fix this properly, it must have a #ifdef around it (as the multiplayer module may be disabled at build-time).

After making this change, it works when rebased on master :

image

The following errors are printed after evaluating the 4 lines in the above screenshot:

ERROR: Invalid named index 'this' for base type Object
   at: (core\math\expression.cpp:1507)
ERROR: Invalid named index 'this_does_not_exist' for base type Object
   at: (core\math\expression.cpp:1507)

This could be surfaced more obviously in the UI when on the Evaluator tab, as it's not obvious that a variable you're requesting does not exist (or there's a syntax error).

@KoBeWi
Copy link
Member

KoBeWi commented Oct 1, 2024

Superseded by #97647
Thanks for your contribution nonetheless.

@KoBeWi KoBeWi closed this Oct 1, 2024
@KoBeWi KoBeWi removed this from the 4.x milestone Oct 1, 2024
@KoBeWi KoBeWi added the archived label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants