Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect "compress_binary_resources" editor setting on scene import #76630

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

gelvinp
Copy link
Contributor

@gelvinp gelvinp commented Apr 30, 2023

ResourceImporterScene::import() did not check the filesystem/on_save/compress_binary_resources editor setting to set FLAG_COMPRESS when saving after import, while EditorNode::save_resource_in_path() did, causing imported scenes (e.g. from gLTF files) to be larger than scenes created by manually saving in the editor.

Closes #71538

@gelvinp gelvinp requested a review from a team as a code owner April 30, 2023 21:21
@Calinou Calinou added this to the 4.1 milestone Apr 30, 2023
@Calinou
Copy link
Member

Calinou commented Jun 18, 2023

Note for users and testers: you must remove the .godot/ folder in the project while the editor is closed for changes from this PR to be effective. Godot will not automatically reimport resources when you toggle the Compress Binary Resources editor setting.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased against master a83eb16), it works. The imported SCN file from the MRP now weighs 1.8 KB instead of 4.8 KB.

@gelvinp gelvinp force-pushed the respect-binary-compress branch from 59ec2e2 to 9408ac0 Compare June 18, 2023 07:55
@akien-mga akien-mga merged commit 8d6c33a into godotengine:master Jun 18, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glTF file import creates files that are too large
3 participants