-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow concurrent buffering and dispatch of input events #76399
Merged
akien-mga
merged 1 commit into
godotengine:master
from
RandomShaper:fix_android_input_anr
May 8, 2023
Merged
Allow concurrent buffering and dispatch of input events #76399
akien-mga
merged 1 commit into
godotengine:master
from
RandomShaper:fix_android_input_anr
May 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawnjelly
approved these changes
May 8, 2023
RandomShaper
force-pushed
the
fix_android_input_anr
branch
2 times, most recently
from
May 8, 2023 06:59
6dca5f5
to
4a6357b
Compare
|
RandomShaper
force-pushed
the
fix_android_input_anr
branch
from
May 8, 2023 07:15
4a6357b
to
f369ed9
Compare
m4gr3d
approved these changes
May 8, 2023
Thanks! |
Any chance this could be cherrypicked before 4.1? |
This PR already has the |
m4gr3d
added a commit
to m4gr3d/godot
that referenced
this pull request
May 12, 2023
Cherry-picked for 4.0.3. |
akien-mga
pushed a commit
to akien-mga/godot
that referenced
this pull request
May 12, 2023
…editor (cherry picked from commit 367061c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75893.
Tagged as platform_android, but it really affects any hypothetical platform where Godot's main thread is not the app main/UI thread.
@m4gr3d, @lawnjelly, in the end I've taken a simpler route than double buffering or flushing a copy of the list.
Sadly, I have no time at the moment to test this. Tagging as such.
Counterpart for 3.x is #76400.
UPDATE: Let me give an explanation of what this PR does:
_parse_input_event_impl()
is the "backend" of input event handling, the function that dispatches the events to the engine and user code. It holds a lock because it can still read/write some common data,