Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Add option to embed dotnet build outputs into the data file #76305

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

RedworkDE
Copy link
Member

Extracted from #73257. Somewhat related issue: #72159

This is largely equivalent to the mono/export/export_assemblies_inside_pck project setting from 3.x.
Adds an export option that, when enabled, embeds the C# build outputs into the pck/zip instead of having them as loose files. For execution these files have to be extracted to some temporary location to be able to load them.

Together with the embed pck option this allows for single file exports of C# project for windows and linux.

Open Question: What is the best place to put the published outputs for execution?
Currently they are extracted into OS::get_singleton()->get_cache_path().path_join("data_" + appname_safe + "_" + arch), which on windows ends up in AppData/Local which is not a folder that can really be cleaned out as per user app installations often end up there and thus these files are likely to remain there forever.

@RedworkDE RedworkDE requested a review from a team as a code owner April 20, 2023 22:50
@Calinou Calinou added this to the 4.x milestone Apr 21, 2023
@RedworkDE RedworkDE force-pushed the net-build-output-embed branch from 9182e90 to 777d959 Compare June 28, 2023 20:20
@neikeq neikeq merged commit 777d959 into godotengine:master Jul 31, 2023
@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Jul 31, 2023
@RedworkDE RedworkDE deleted the net-build-output-embed branch July 31, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants