Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Snap 2d Transforms To Pixel gaps #76277

Conversation

jtakakura
Copy link
Contributor

Fixes #56793

@jtakakura jtakakura requested a review from a team as a code owner April 20, 2023 03:06
@akien-mga akien-mga added this to the 4.1 milestone Apr 20, 2023
@akien-mga
Copy link
Member

I haven't looked at details but I believe this might solve the issue in some cases, and worsen the situation in other cases. @lawnjelly did a deep dive into this stuff for Godot 3 and this was a huge can of worms.

@jtakakura
Copy link
Contributor Author

@lawnjelly Please tell me how to test this issue if you know.
This issue is a significant impact on pixel game developers.

@lawnjelly
Copy link
Member

Here's a list of some reading for you:
#57221 (comment)

We did try different round modes if I remember right (was a couple years ago).

@jtakakura
Copy link
Contributor Author

jtakakura commented Apr 24, 2023

@lawnjelly Thank you for your reply
I found the reason you revert the similar modifications in #46615 (comment)
I understood this problem is very complicated

@lawnjelly
Copy link
Member

BTW this is not trying to discourage work on this area, it is clearly quite important to a lot of users, but tricky to get right (I just gave up with lack of patience in the end 😃 , might have to revisit it now we are doing 2D interpolation ).

Probably will need some proper thought and a proposal to discuss how to proceed to properly solve this area.

@akien-mga
Copy link
Member

Also, I think if we can't find a one-size-fits-all solution, but can design different solutions that work in different use cases, we could implement those multiple solutions and make them selectable (and provide guidance on which mode to use for which use case).

@jtakakura
Copy link
Contributor Author

Sorry for the late reply.
I looked at ways to solve this issue but I couldn't come up with a one-size-fits-all solution.
Then I would like to consider how to solve referring to the following PR.
Thanks.

#46615

@jtakakura jtakakura closed this May 5, 2023
@jtakakura jtakakura deleted the fix-snap-2d-transform-to-pixel-gaps branch May 5, 2023 23:39
@KoBeWi KoBeWi added the archived label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan: 2D Pixel Snap not working
4 participants