-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement zooming and panning in the profiler #76055
Conversation
I think being able to click and drag to highlight/select a particular area of the graph and have it zoom into that section would be an excellent addition to these changes. |
This would be really helpful, is there a reason it wasn't merged for 4.x so far? |
The improvement hasn't been decided on and this hasn't been reviewed yet, might be once 4.2 is released and new features are focused on once again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (rebased on top of master
6afd320), it works as expected. Code looks good to me at a glance.
I suggest making panning work with the right mouse button in addition to the middle mouse button, so that it works on laptop trackpads out of the box too (where middle-clicking is usually not possible easily).
PS: We should really add a grid to the profiler (and visual profiler) backgrounds, so that the user is more aware of the current zoom level 🙂
d76b5a9
to
fc8499a
Compare
fc8499a
to
08e3048
Compare
Any progress on this? It would be amazing to have! The ui is almost useless because of the microscopic frames and tiny framestep buttons. |
There are merge conflicts that need to be resolved first. @reach-satori Could you look into rebasing this PR against the latest |
08e3048
to
523ae1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected.
523ae1e
to
c6492de
Compare
Thanks! |
As mentioned in godotengine/godot-proposals#2045 and the quite old #5682. Uses mouse wheel for zooming and middle click drag for panning. Little demonstration included below.
simplescreenrecorder-2023-04-14_14.24.40.mp4