Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement zooming and panning in the profiler #76055

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

reach-satori
Copy link
Contributor

As mentioned in godotengine/godot-proposals#2045 and the quite old #5682. Uses mouse wheel for zooming and middle click drag for panning. Little demonstration included below.

simplescreenrecorder-2023-04-14_14.24.40.mp4

@avedar
Copy link

avedar commented Apr 15, 2023

I think being able to click and drag to highlight/select a particular area of the graph and have it zoom into that section would be an excellent addition to these changes.
Thanks for the improvements regardless!

@jamesmcm
Copy link

This would be really helpful, is there a reason it wasn't merged for 4.x so far?

@AThousandShips
Copy link
Member

The improvement hasn't been decided on and this hasn't been reviewed yet, might be once 4.2 is released and new features are focused on once again

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 6afd320), it works as expected. Code looks good to me at a glance.

I suggest making panning work with the right mouse button in addition to the middle mouse button, so that it works on laptop trackpads out of the box too (where middle-clicking is usually not possible easily).

PS: We should really add a grid to the profiler (and visual profiler) backgrounds, so that the user is more aware of the current zoom level 🙂

@reach-satori reach-satori force-pushed the plot_zoom branch 2 times, most recently from d76b5a9 to fc8499a Compare December 21, 2023 19:45
@YuriSizov YuriSizov changed the title Profiler plot zoom and pan Implement zooming and panning in the profiler Dec 22, 2023
@jakkarn
Copy link

jakkarn commented Sep 14, 2024

Any progress on this? It would be amazing to have! The ui is almost useless because of the microscopic frames and tiny framestep buttons.

@Calinou
Copy link
Member

Calinou commented Sep 16, 2024

Any progress on this? It would be amazing to have! The ui is almost useless because of the microscopic frames and tiny framestep buttons.

There are merge conflicts that need to be resolved first.

@reach-satori Could you look into rebasing this PR against the latest master branch? See Pull request workflow for instructions 🙂

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Nov 29, 2024
@akien-mga akien-mga merged commit b66c1d0 into godotengine:master Nov 29, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants