Fix crashes caused due to missing type specifier on visual shader editor #75809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader Editor crashes engine due to index out of bounds.
kleonc
approved these changes
Apr 8, 2023
Chaosus
approved these changes
Apr 8, 2023
|
Thanks! And congrats with your first contribution to the Godot Engine! |
|
Cherry-picked for 4.0.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75790
This PR adds (appears to be) a missing vector type specifier for
Vector2variant ofCeilfunction registered in visual shader editor.Cause
Creating a Ceil/Vector2 node on visual shader editor crashes the engine, due to the out of bounds error.
this is caused by the fact that the
p_opsforAddOptionstruct corresponding to Ceil/Vector2 has only 1 item in it, instead of 2 items (both function specifier and vector type specifier) like the engine expects.upon node setup, it tries to access the non-existent 2nd item to figure out which vector type this node should handle, which causes out of bounds.