Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak environment in the Advanced Import Settings dialog #75787

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Apr 7, 2023

Use a gradient sky to improve visibility in shaded areas, while also helping the user orient themselves. The bottom of the sky is black, while the top of the sky is white.

This change also makes it so that the Default Clear Color project setting no longer affects the Advanced Import Settings dialog.

If we agree upon this change, a similar change can be made to mesh and material previews in the inspector.

Testing project: test_advanced_import_settings_preview.zip

Preview

Notice how you can actually distinguish shaded areas from each other now.

Before After
Screenshot_20230407_180921 Screenshot_20230407_180816

@Calinou Calinou requested a review from a team as a code owner April 7, 2023 16:11
@Calinou Calinou added this to the 4.x milestone Apr 7, 2023
Use a gradient sky to improve visibility in shaded areas,
while also helping the user orient themselves. The bottom of the sky
is black, while the top of the sky is white.

This change also makes it so that the Default Clear Color project setting
no longer affects the Advanced Import Settings dialog.
@Calinou Calinou force-pushed the advanced-import-settings-tweak-environment branch from 1bdf216 to 7259985 Compare April 8, 2024 23:04
Copy link
Contributor

@smix8 smix8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While all other prs that touch the preview are stuck in fix-me or bike-shed hell this PR fixes the immediate issue that you can not see your rotated asset on a 100% grey backdrop. Everything else can still be improved later.

Copy link
Contributor

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yes!

Congratulations on a happy one year PRnniversary.
I have no idea how this flew under the radar, but let's get this in for 4.3!

@lyuma lyuma modified the milestones: 4.x, 4.3 Apr 13, 2024
@akien-mga akien-mga merged commit d5fd611 into godotengine:master Apr 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the advanced-import-settings-tweak-environment branch April 16, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants