GDScript: Misc fixes and improvements for signature generation #75691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexeev
changed the title
BitMasks and Variant/voidBitFields and Variant/void
* Use type hints for `@GlobalScope` enums. * Use plain `int` for `BitMask<T>`. * Fix type hints for typed arrays. * Use `Variant` and `void` type hints. * Discard unnecessary class prefix.
dalexeev
force-pushed
the
gds-fix-signature-generation
branch
from
bbfccff to
9df96e9
Compare
dalexeev
changed the title
BitFields and Variant/void
|
There is still room for improvements (add completion options to override script methods, discard unnecessary class prefix considering custom classes/scripts, etc.), but for now I'd rather stick with a small PR. Test project: test_signature_generation.zip. |
adamscott
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
The PR was reviewed by the GDScript team. This fixes an important issue that will help users to write better typed code.
As discussed, this autocomplete feature will only work, currently, with virtual native functions. So we don't have to worry, for now, to autocomplete typed functions for non-typed existing functions.
Thanks for your PR! Very appreciated.
YuriSizov
approved these changes
Apr 14, 2023
|
Thanks! |
This was referenced May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some type hints that are added to the function signature if the
text_editor/completion/add_type_hintseditor setting is enabled.@GlobalScopeenums (support added in Make global scope enums accessible as types in GDScript #73590).intforBitMask<T>as this is not currently supported in GDScript (see also DisplayBitField[Enum]in docs to distinguish fromEnum#74641).Variantandvoidtype hints.Before
1.mp4
After
2.mp4
Closes #75311.
Closes #74593.