Fix clearing custom cursor

[AThousandShips]

Fixes #74508

Clearing the cursor in Windows fails because the cache is not cleared before calling to update cursor.

[akien-mga]

The logic is the same on other platforms, should it be changed too?

Linux:

                // Reset to default system cursor
                if (img[p_shape]) {
                        cursors[p_shape] = XcursorImageLoadCursor(x11_display, img[p_shape]);
                }

                CursorShape c = current_cursor;
                current_cursor = CURSOR_MAX;
                cursor_set_shape(c);

                cursors_cache.erase(p_shape);

macOS:

                // Reset to default system cursor.
                if (cursors[p_shape] != nullptr) {
                        cursors[p_shape] = nullptr;
                }

                cursor_update_shape();

                cursors_cache.erase(p_shape);

[AThousandShips]

Oh probably yeah, will take a look there too, cannot test the effect myself though

[AThousandShips]

This is where it causes a problem in the Windows implementation:

godot/platform/windows/display_server_windows.cpp

Lines 1727 to 1731 in 5f2137a

	if (cursors_cache.has(p_shape)) {
	SetCursor(cursors[p_shape]);
	} else {
	SetCursor(LoadCursor(hInstance, win_cursors[p_shape]));
	}

[AThousandShips]

Updated to include MacOS and Linux as well as I was told the bug affected those as well, cannot test for those platforms myself however.

[akien-mga]

Thanks!

[AThousandShips]

Thank you!