Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blend import: Allow importing active_collection_only #73941

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Blend import: Allow importing active_collection_only #73941

merged 1 commit into from
Jun 3, 2024

Conversation

Jummit
Copy link
Contributor

@Jummit Jummit commented Feb 25, 2023 •
edited by fire
Loading

This corresponds to the Include > Limit to > Active Collection GLTF export option in Blender and is useful when using collections which are instanced in a "main" collection.

Fixes: godotengine/godot-proposals#6363

@Jummit Jummit requested a review from a team as a code owner February 25, 2023 18:14
@Calinou Calinou added this to the 4.x milestone Feb 25, 2023
@Jummit Jummit marked this pull request as draft February 25, 2023 18:58
@Jummit Jummit marked this pull request as ready for review February 25, 2023 19:02
@fire
Copy link
Member

fire commented Feb 26, 2023

If you want, I can write a proposal for this for you. Want to have matching proposals for feature enhancements.

This is put on the milestone after 4.0.

@Jummit
Copy link
Contributor Author

Jummit commented Feb 26, 2023

If you want, I can write a proposal for this for you. Want to have matching proposals for feature enhancements.

This is put on the milestone after 4.0.

Sure, go for it. The use case is importing blend files that have collections that are instanced, but not active.

@fire fire mentioned this pull request Feb 26, 2023
Closed
@AThousandShips AThousandShips changed the title Blend import: Ability to import only the active collection Blend import: Allow importing only the active collection May 29, 2024
@AThousandShips
Copy link
Member

A rebase to check if it's still working and getting CI to run would be good

@Jummit Jummit force-pushed the active-collection branch from b38a28e to a373709 Compare May 29, 2024 15:09
@Jummit
Copy link
Contributor Author

Jummit commented May 29, 2024

A rebase to check if it's still working and getting CI to run would be good

Done.

@Jummit Jummit force-pushed the active-collection branch 2 times, most recently from 8faa55b to 19b8479 Compare May 31, 2024 16:36
@Jummit Jummit force-pushed the active-collection branch from 19b8479 to c182adc Compare May 31, 2024 16:37
@fire fire changed the title Blend import: Allow importing only the active collection Blend import: Allow importing active_collection_only May 31, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jun 3, 2024
@akien-mga akien-mga merged commit bc7a7a4 into godotengine:master Jun 3, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Jummit Jummit deleted the active-collection branch June 3, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement topic:import topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Blend import: Ability to import only the active collection
5 participants
@Jummit @fire @AThousandShips @akien-mga @Calinou