Disallow assignment to constants and expressions #7390
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojidar-bg
commented
Dec 29, 2016
| @@ -2014,7 +2023,7 @@ void GDParser::_parse_block(BlockNode *p_block,bool p_static) { | |||
| } break; | |||
| default: { | |||
|
|
|||
| Node *expression = _parse_and_reduce_expression(p_block,p_static,false,true); | |||
| Node *expression = _parse_and_reduce_expression(p_block,p_static,true,true); | |||
There was a problem hiding this comment.
I'm not really sure why this was left to false (it is p_reduce_const), would be nice if @reduz confirms 😃
There was a problem hiding this comment.
I would say copy paste mistake :)
There was a problem hiding this comment.
@akien-mga You think so? It is never true in the other parts of the code 😆
Let's see if we break anything though...
There was a problem hiding this comment.
turning back to false fixes #7412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6221, fixes #6824