Fix preview window size in visual shader editor #72954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Feb 9, 2023
Comment on lines
4932
to
+4933
| preview_window->popup_centered(); | ||
| preview_window->set_size(Size2(400 * EDSCALE, 600 * EDSCALE)); |
There was a problem hiding this comment.
That's weird that this would be the fix. Sounds like there's a deeper issue if it's not working to set the size before showing the window.
Isn't this a recent regression? Might be worth finding what's the culprit before working it around.
CC @Sauermann maybe
There was a problem hiding this comment.
popup_centered was changed recently in #62179
There was a problem hiding this comment.
I believe, that this change will center the top-left corner of the window, but not the window itself.
|
Superseded by #72991. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #72949