C#: Make include scripts contents an export option

[RedworkDE]

Includes and requires #72895
Resolves a TODO comment about this, but really this things is just a detour from me looking into embedding the C# outputs into the pck (which really should be such an option).
For backwards compatibility, the sources are preserved if either the project settings or the export option is set. But if this somehow makes it before 4.0 or the minor breakage is acceptable (I don't really think that there is anyone actually depending on having the C# sources available at runtime), the last commit completely removes the project setting. I will either squash or remove it depending on reviews.

[neikeq]

Oh, does this implement a way for export plugins to register custom export settings that appear in the export dialog?

[RedworkDE]

Yes, that is the linked PR / first commit here.

(The second option is not part of this PR)

[neikeq]

That's really great. This is something I always wanted to implement. Currently, there are few C# export settings but in the future there will be more.

[raulsntos]

The Core PR (#72895) should be merged first, then this PR rebased. Since they're both in the 4.1 milestone, @neikeq are we OK with the breaking change in commit d6c6d1dab7c7b207927a8bccf602bec8bea1e49e that removes the dotnet/export/include_scripts_content ProjectSetting?

[RedworkDE]

Re: breaking change: On github I can find 10 repos that have enabled this project setting: https://github.com/search?q=export%2Finclude_scripts_content%3Dtrue+path%3Aproject.godot&type=code
Of those, only https://github.com/Srynetix/godot-nature-of-code/blob/master/chapters/SceneExplorer.cs#L188-L197 has actually found a use for it, the others, as far as I can tell, only have the option enabled but don't actually use the contents.

[YuriSizov]

#72895 was merged, so this needs its rebase. You should also squash commits, the one removing the setting doesn't look like it needs to be standalone.

Regarding removing the setting, this is okay, generally speaking. But I'll leave it to @godotengine/dotnet to decide :)

[RedworkDE]

Since nobody was really objecting to removing the (recently renamed) project setting, I removed it, instead of having this be that odd one out setting that can be toggled from two places.

[neikeq]

I'm fine with removing the setting, since this is a very niche option anyway.

[YuriSizov]

Thanks!

[albinaask]

Would this change mean that C# scripts from different pcks can coexist and cooperate? Like if you had DLCs or the like?

[RedworkDE]

Would this change mean that C# scripts from different pcks can coexist and cooperate? Like if you had DLCs or the like?

In its current state no, but it can be the basis for a future system like that.

[albinaask]

I see. Thank you!