Decrease overhead of WorkerThreadPool task processing #72716
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes threads to accept and process work in batches so that they synchronize less often.
As a bonus, this also hoists the loop for
add_template_group_task()
into the header file so that the loop body can be inlined.This way,
add_template_group_task()
and its derivatives (namely, parallelforeach()
) can have optimal performance, so there is no longer any need to do manual batching like inRaycastOcclusionCull::Scenario::_transform_vertices_thread()
:godot/modules/raycast/raycast_occlusion_cull.cpp
Lines 339 to 390 in 13f0158