Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Fix match branches return check on release #72400

Merged

Conversation

vnen
Copy link
Member

@vnen vnen commented Jan 30, 2023

The check for existence of return only existed on debug builds for match branches. This could lead on an invalid error after exporting. Now this is checked on relase too, so it works the same as the editor.

Fix #55045

The check for existence of `return` only existed on debug builds for
match branches. This could lead on an invalid error after exporting. Now
this is checked on relase too, so it works the same as the editor.
@vnen vnen added this to the 4.0 milestone Jan 30, 2023
@vnen vnen requested a review from a team as a code owner January 30, 2023 18:22
@akien-mga akien-mga merged commit dc7fb30 into godotengine:master Jan 30, 2023
@akien-mga
Copy link
Member

Thanks!

@vnen vnen deleted the gdscript-match-release-consistency branch January 31, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return value within match keyword in typed function will cause parse error in the release export
2 participants