Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreachable code warning for elif block #72330

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

MinusKube
Copy link
Contributor

Fixes #71715

When a parse_if matches an elif token, an else_block suite was created, but was not set as the current_suite, causing the elif parse to set has_return to true in the whole if/elif/else suite, even if the if doesn't return.

@MinusKube MinusKube requested a review from a team as a code owner January 29, 2023 19:33
@akien-mga akien-mga added this to the 4.0 milestone Jan 29, 2023
@akien-mga akien-mga merged commit eee3432 into godotengine:master Feb 6, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script Editor gives inappropriate "unreachable code detected" warning
3 participants