Fix get_parent_anchorable_rect() not returning the correct size in some cases #72204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @Sauermann |
|
I have tested the PR and it fixes the MRP of the linked issue. However a special case is not taken into consideration:
These steps result in the following SceneTree:
In this case the TextureRect is again not displayed correctly. |
MinusKube
force-pushed
the
anchorable_rect_editor_bug
branch
from
9dc8fe3 to
0f512a6
Compare
|
Okay, fixed! Now I compare the current viewport to the edited scene root's parent viewport instead of the root viewport directly. |
Sauermann
approved these changes
Jan 28, 2023
YuriSizov
approved these changes
Feb 6, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67303
When a control is at the top-level of a subviewport (e.g. in a Window or in a SubviewportContainer), it was considered as if it was at the top-level of the edited scene viewport, thus the parent anchorable rect was computed using the
viewport_widthandviewport_heightproperties, instead of using the real subviewport size.