-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Improve warning for path casing. #71975
[Windows] Improve warning for path casing. #71975
Conversation
98c1e58
to
e26843f
Compare
e26843f
to
30df7b4
Compare
30df7b4
to
1929697
Compare
1929697
to
d52b882
Compare
d52b882
to
deccfaf
Compare
deccfaf
to
27311fb
Compare
27311fb
to
34cae5b
Compare
34cae5b
to
3679ea5
Compare
Poke @bruvzg |
Gonna just test this on my own build for completeness today unless you did so @bruvzg, haven't rested this for the better part of a year so wanna make sure |
For the reference, I have only looked at the code, and it looks fine to me, have not tested it on Windows. |
Had it in my working branch and it correctly reports path casing errors in full paths like |
Thanks! |
Thank you! |
Expands the warning for case mismatch for paths, restricted to paths in
res://
anduser://
and relative paths, partially to avoid false positives I ran into with fonts (it seems that the system font lookup gives you WINDOWS regardless of the actual spelling on your computer), and my reasoning is that absolute paths are unlikely to be portable anyway, nor do I even think they are advisable in a project.Related to #52231 but not a complete solution for that, but probably relevant for the implementation. But I think a more helpful check here will still be needed for dynamic cases even if hardcoded paths in scripts and scenes should be fixed some way.
Edit:
There is a now unused fix for casing in
os_windows
but I'm leaving that there for now unless told otherwise.