Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify AudioStreamPolyphonic #71906

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Simplify AudioStreamPolyphonic #71906

merged 1 commit into from
Jan 23, 2023
+16 −37

Conversation

reduz
Copy link
Member

@reduz reduz commented Jan 23, 2023

  • Make AudioStreamPolyphonic not requre a polling thread (simpler, faster)
  • Improve error reporting in AudioStreamPlayer*::get_stream_playback() error reporting to improve usability.

@reduz
Simplify AudioStreamPolyphonic
4383b5a 
* Make AudioStreamPolyphonic not requre a polling thread (simpler, faster)
* Improve error reporting in AudioStreamPlayer*::get_stream_playback() error reporting to improve usability.
@reduz reduz requested review from a team as code owners January 23, 2023 09:49
@Calinou Calinou added this to the 4.0 milestone Jan 23, 2023
@akien-mga akien-mga merged commit 809bd94 into godotengine:master Jan 23, 2023
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur mentioned this pull request Apr 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:audio
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@reduz @akien-mga @Calinou