Sort decals and lights based on camera origin #71709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jan 20, 2023
Also implement sort_offset for decals Co-authored-by: Hugo Locurcio <[email protected]>
clayjohn
force-pushed
the
decals-lights-sorting
branch
from
717072a to
49bebf2
Compare
|
Pushed the requested changes. Should be good now |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also implement sort_offset for decals
Fixes: #49639
Supersedes: #60253
Follow up to: #69998
Primarily this PR is about ensuring that decals and lights do not change their calculated distance when the camera rotates. For both this is important if distance fade is enabled. For decals, this is important so decals do not flicker in and out when the camera rotates.
To fix decals changing sort order when the camera moves I have extended the sort-offset to decals.
In the sorting code for both I have removed redundancy and avoided calculating distance more than necessary.
Finally, this PR also hides the sorting properties from most VisualInstance3D-derived types as only GeometryInstances and decals can use them. And Decals can only use sort-offset.