-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Sync Plane
with Core
#71456
C#: Sync Plane
with Core
#71456
Conversation
2d43d2e
to
a696621
Compare
@akien-mga Would it be OK to also rename the method in Core, or is it too late? To fix the inconsistency with |
Ah yes, a method named |
a696621
to
94b3d34
Compare
- Add `Plane(Vector3)` constructor. - Rename `IntersectRay` to `IntersectsRay`. - Rename `IntersectSegment` to `IntersectsSegment`. - Replace `Center` property with `GetCenter` method. - Add and fix documentation about the _normal_ parameter to Core and C# documentation.
94b3d34
to
7a19c87
Compare
Thanks! |
Plane(Vector3)
constructor.IntersectRay
toIntersectsRay
.s
in Core.IntersectSegment
toIntersectsSegment
.s
in Core.Center
property withGetCenter
method.GetCenter
method (AABB
,Rect2
, andRect2i
).center
method toget_center
in Plane. #71474.GetCenter
methods withCenter
properties instead1.Footnotes
This is not possible in GDScript because it doesn't support readonly properties but in C# we can. ↩