-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PROPERTY_USAGE_NEVER_DUPLICATE
flag and use for script
#71142
Add PROPERTY_USAGE_NEVER_DUPLICATE
flag and use for script
#71142
Conversation
Changes to the PropertyUsageFlags enum need to be synchronized with the enum in C# source generators:
|
558ad7e
to
5a89ef0
Compare
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/GodotEnums.cs
Outdated
Show resolved
Hide resolved
07a6ce9
to
15c15e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by production team.
We thought it would be worth furthering the compat breakage a bit by moving NEVER_DUPLICATE
next to ALWAYS_DUPLICATE
in the enum, so they're adjacent in the docs.
This likely fixes #68666 (only for Resources stored/duplicated after this PR; if something was already saved with |
15c15e2
to
ab5b72c
Compare
ab5b72c
to
2a65f68
Compare
Thanks! |
This PR fixes #33079 and supersedes #41923.
This PR is split into two commits:
PROPERTY_USAGE_NEVER_DUPLICATE
flag and use for scriptduplicate(true)
on custom Resource returns empty Resource. #33079 and supersedes Add PROPERTY_USAGE_ALWAYS_SHARE_ON_DUPLICATE flag #41923.Minimal reproduction project in GDScript: test_33079.zip