Add SceneTree.unload_current_scene() #71105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the unload immediate or like queue_free (a frame later)? |
akien-mga
reviewed
Jan 9, 2023
akien-mga
reviewed
Jan 9, 2023
akien-mga
approved these changes
Jan 9, 2023
Maran23
reviewed
Jan 9, 2023
Provides an obvious way to unload the currently loaded scene (which is nowhere to be found in the docs). The SceneTree.change_scene_to() method must now always provide a valid PackedScene. Fixes godotengine#63565.
reduz
force-pushed
the
unload-current-scene
branch
from
051b5b2 to
e5f2c44
Compare
|
Thanks! |
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jan 15, 2023
Regression from godotengine#71105. Fixes godotengine#71363.
akien-mga
reviewed
Jan 15, 2023
Comment on lines
+1136
to
+1137
| Node *new_scene = p_scene->instantiate(); | ||
| new_scene = p_scene->instantiate(); |
There was a problem hiding this comment.
Ouch memory leak. Fixed in #71459.
Streq
pushed a commit
to Streq/godot
that referenced
this pull request
Feb 9, 2023
Regression from godotengine#71105. Fixes godotengine#71363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an obvious way to unload the currently loaded scene (which is nowhere to be found in the docs). The SceneTree.change_scene_to() method must now always provide a valid PackedScene.
Fixes #63565.