Added more missing properties/methods to the Godot converter

[Maran23]

While converting a bigger project I found some properties/methods which were not yet covered by the converter.

The following properties/methods are converted now:

• icon_align -> icon_alignment (get + set were already converted)
• rect_min_size -> custom_minimum_size
• get_tree().set_input_as_handled() -> get_viewport().set_input_as_handled()
• _unhandled_key_input(event: InputEventKey) -> _unhandled_key_input(event: InputEvent)

And C# equivalents

[akien-mga]

For the methods/properties, there's also a table for C# replacements which would be good to sync.

[Maran23]

For the methods/properties, there's also a table for C# replacements which would be good to sync.

Done. :)
Note that there was no equivalent of rect_min_size (RectMinSize) to minimum_size (MinimumSize) in the converter for C#.
So I skipped custom_minimum_size for now.

[Maran23]

For the methods/properties, there's also a table for C# replacements which would be good to sync.

Just had a look in the history. The rect_ conversions were added here: #64396
Looks like the C# functions were just forgotten for the rect_ functions then.
I can create another PR where I add them for C# as well. Is that fine?

[acedogblast]

From what I understand of the code there is a problem where if one property spelling exists for multiple nodes they all will be renamed even if they are incompatible. Should it be better to do renaming node properties and functions done on a node to node basis rather than the current global perspective?

[YuriSizov]

@acedogblast It works as it does because we can't be sure with untyped GDScript what type does a property hold. And even for typed, I don't think we do any kind of static analysis.

[acedogblast]

Then how about the vertical and horizontal alignment for labels. In Godot 3.5 they are referred to as "align" and "valign" in Godot 4.0 they have been renamed to "horizontal_alignment" and "vertical_alignment". In both versions they can only be assigned 4 same possible values. I was not sure if we can add that to the list as "align" may be used in other nodes with a different context.

[YuriSizov]

If the expected result is mostly positive, we can add it. If it has a big negative impact on an average codebase, then we shouldn't add it. It will never be completely safe as users may declare any sort of variable or method, and we can conflict with that. Which is why we have a disclaimer that this convertor operates as a best effort tool.

[Maran23]

I was not sure if we can add that to the list as "align" may be used in other nodes with a different context.

Yeah, align is used in many nodes. valign might be a feasible though.

[akien-mga]

Thanks!