Add unit test for VisualShader

[jainl28patel]

part of #43440
Adds test for VisualShader class test the following

• Parameter with getter and setter
• Node Creation, deletion, editing, replacing and removing
• Varyings
• Invalid Entries for above three

Tests are compiled and run successfully on my device

[Chaosus]

You need to squash the commits as required by our pipeline (see https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#updating-your-branch)

[Maran23]

I wonder if we can also test the generate_code method?

[jainl28patel]

I wonder if we can also test the generate_code method?

Yeah sure. Actually I didn't tested it because it wasn't the part of VisualShader. I will make changes by today/tomorrow 👍 .
If there are any other changes please let me know.
Also is there a way to run the Static checks on my system before I make commit so that i have cleaner commits.

[jainl28patel]

I saw the code and I feel that generate_code method should not be checked as a part of VisualShader class as it belongs to a different class.
Is it necessary to test it in VisualShader ?

[jainl28patel]

@Chaosus please review if any other changes are needed.

[Chaosus]

Ok, thanks for contribution, I think it's fine now.

[jainl28patel]

Ok, thanks for contribution, I think it's fine now.

Thankyou very much for guiding as it was my 1st experience and was amazing 🙏 .
Need one last help. Why is Linux build and MacOS failing ? It didn't failed last 2 times and i only changed the for{} loop.

[Chaosus]

Why is Linux build and MacOS failing ? It didn't failed last 2 times and i only changed the for{} loop.

I don't know, but my guess, you should try to declare the variables outside of SUBCASE labels (at the beginning of CASE).

[jainl28patel]

Why is Linux build and MacOS failing ? It didn't failed last 2 times and i only changed the for{} loop.

I don't know, but my guess, you should try to declare the variables outside of SUBCASE labels (at the beginning of CASE).

I was doing that before but didn't gave any ERRORS. Can it happen because I am deleting the object pointer every time in the for loop using memdelete(vsn.ptr()) ?

[Chaosus]

I was doing that before but didn't gave any ERRORS. Can it happen because I am deleting the object pointer every time in the for loop using memdelete(vsn.ptr()) ?

Ah yes, you should not call memdelete on Ref counted objects - they would automatically free the memory when goes out of scope.

[Chaosus]

Thanks!