Add open scene button in Inspector for PackedScene resource #69938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature is great from a usability point of view if you're storing packed scenes in an export variable. Don't have much time to review the code though. Edited: It's a bit short so may be easy to review. |
fire
reviewed
Dec 12, 2022
|
|
||
| void PackedSceneEditor::_notification(int p_what) { | ||
| switch (p_what) { | ||
| case NOTIFICATION_ENTER_TREE: |
There was a problem hiding this comment.
I thought we needed a [[fallthrough]] here? Did something change?
There was a problem hiding this comment.
[[fallthrough]] is not required if the case does nothing on its own. See #58151.
fire
reviewed
Dec 12, 2022
fire
approved these changes
Dec 12, 2022
timothyqiu
force-pushed
the
open-packed-scene
branch
from
f922b1e to
9af9af5
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#3338
Adds an "Open Scene" button when editing a PackedScene resource: