Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AnimationPlayer play backward doesn't process just current key & AnimationPlaybackTrack seeking for preview #69588

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Dec 5, 2022

To process the key at the moment of playback, it must be seeked prior to playback. Follow up #69336.
Also, Sub-AnimationPlayer should not play when seeking while stopped. Follow up #69357.

@TokageItLab TokageItLab added this to the 4.0 milestone Dec 5, 2022
@TokageItLab TokageItLab changed the title Fix AnimationPlayer play backward doesn't process current key Fix AnimationPlayer play backward doesn't process just current key Dec 5, 2022
@TokageItLab TokageItLab requested a review from a team December 5, 2022 05:02
@TokageItLab TokageItLab changed the title Fix AnimationPlayer play backward doesn't process just current key Fix AnimationPlayer play backward doesn't process just current key & AnimationPlaybackTrack seeking for preview Dec 5, 2022
@akien-mga akien-mga merged commit 777dca3 into godotengine:master Dec 5, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga changed the title Fix AnimationPlayer play backward doesn't process just current key & AnimationPlaybackTrack seeking for preview Fix AnimationPlayer play backward doesn't process just current key & AnimationPlaybackTrack seeking for preview Dec 9, 2022
@TokageItLab TokageItLab deleted the fix-play-bw branch February 14, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants