[macOS] Improve maximized and non-resizable modes handling. #69380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I encountered the same issue with borderless windows, because |
akien-mga
approved these changes
Dec 2, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no dedicated "maximized" window state on macOS. Zoom button is resizing it to max. allowed size (current screen size or max. window size). For non-resizable window, current size is max. size, so it's always considered to be zoomed by OS.
This PR replaces unreliable
isZoomedwith window/screen frame rect comparison to ensureset_size/positionwork with non-resizable windows and ignored for maximized windows (required for initial maximized window size to work correctly).Also disables zoom button for non-resizable windows.
Fixes #69116