Rename references to audio device, capture_device to output_device, input_device respectively #69120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souplamp
force-pushed
the
audio-function-rename
branch
2 times, most recently
from
7be6a9e to
c7b5ade
Compare
souplamp
changed the title
souplamp
force-pushed
the
audio-function-rename
branch
5 times, most recently
from
3601f28 to
01b4d94
Compare
souplamp
force-pushed
the
audio-function-rename
branch
from
01b4d94 to
09a8c2b
Compare
reduz
approved these changes
Jan 24, 2023
|
@souplamp This needs a rebase |
Change instances of audio properties 'device' to 'output_device', and instances of audio properties 'capture_device' to 'input_device', as well as their subsequent getter & setter functions. Update the docs to reflect these changes, as well as the 3-to-4 converter for GDScript and CSharp to make proper conversions (only exception is 'device' since that name is too vague and might replace non-AudioServer related instances, such as user comments and variables). This does not change internal references to references like 'Render Client' and 'Capture Client' in WASAPI; such is outside the scope of this commit. This also does not change ALSA's references, considering that it uses 'device' to mean input and output interchangeably. Other references are changed, however where applicable, to be consistent with the new AudioServer methods and property names.
akien-mga
force-pushed
the
audio-function-rename
branch
from
09a8c2b to
5300daa
Compare
|
I did the rebase and updated the PR. |
|
Thanks! |
|
Yuri! Sorry I missed the notification. Thank you Rémi for the rebase!! |
akien-mga
added a commit
to OverloadedOrama/godot
that referenced
this pull request
Feb 9, 2023
…69120. - Rename all instances of `capture_start()` and `capture_end()` to their new names. Fixes godotengine#72892. - More internal renames to match what was started in godotengine#69120. - Use `override` consistently so that such refactoring bugs can be caught. - Harmonize the order of definition of the overridden virtual methods in each audio driver. - Harmonize prototype for `set_output_device` and `set_input_device`. Co-authored-by: Rémi Verschelde <[email protected]>
akien-mga
added a commit
that referenced
this pull request
Feb 9, 2023
Further refactoring to AudioDriver implementations after #69120, fixes PulseAudio microphone input
JeffVenancius
pushed a commit
to JeffVenancius/godot
that referenced
this pull request
Mar 3, 2023
…69120. - Rename all instances of `capture_start()` and `capture_end()` to their new names. Fixes godotengine#72892. - More internal renames to match what was started in godotengine#69120. - Use `override` consistently so that such refactoring bugs can be caught. - Harmonize the order of definition of the overridden virtual methods in each audio driver. - Harmonize prototype for `set_output_device` and `set_input_device`. Co-authored-by: Rémi Verschelde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: #5893.
This PR changes many audio properties and methods so that they better reflect their purpose (a 'device' is an audio output device, while a 'capture device' is an audio input device).
AudioServer
Properties:
Methods:
In addition to the changes above, the 3-to-4 converter will convert instances of the old names to the new names (one exception: 'device' was left out since the name is too vague and may replace user variables).
Most references in the audio drivers have been changed to maintain consistency as well; the only exceptions are drivers that use 'device' interchangeably at times (WASAPI, ALSA), and certain internal references in WASAPI, including
eRenderandeCapturethat are out of scope for this PR.This is a change that breaks compatibility for this particular feature if used in previous betas.