Fix GPUParticles not rendering in doubles build of the engine. #68425
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, Clay John. It works. I'm not a reviewer but I confirm that it fix #67545 for me. |
akien-mga
approved these changes
Nov 9, 2022
|
Needs a rebase to pass godot-cpp CI. |
real_t was mistakenly used in uniform structs causing a mismatch between the GPU uniform and the CPU uniform
clayjohn
force-pushed
the
RD-doubles-particles
branch
from
09f7f43 to
4aab9cb
Compare
Done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #67545
May help: #58333
real_twas mistakenly used in uniform structs causing a mismatch between the GPU uniform and the CPU uniform. On the GPU side these are all floats, so they should be floats here too.