Regenerate GL loader code with GLAD 2 #68372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riteo
force-pushed
the
glad2
branch
3 times, most recently
from
9fa8a46 to
f6397bf
Compare
GLAD 1 creates unusable loaders for EGL, while the newly released GLAD 2 does not, so for consistency I thought that it would be a good idea to uniform things beforehand. While it had some API changes some renames were all that was needed and everything works like before, at least on the Wayland branch. I've kept the structure identical, although this new generator has quite a few hefty features, such as a single header mode. I've also added GLAD to `thirdparty/README.md`, but I haven't specified that in the commit title because it's a very small "fix".
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLAD 1 creates unusable loaders for EGL, while the newly released GLAD 2 does not, so for consistency I thought that it would be a good idea to uniform things beforehand. While it had some API changes some renames were all that was needed and everything works like before, at least on the Wayland branch.
I've kept the structure identical, although this new generator has quite a few hefty features, such as a single header mode.
I've also added GLAD to
thirdparty/README.md, but I haven't specified that in the commit title because it's a very small "fix".This patch paves the way for dynamic EGL/GLX loading (very, very preliminarily, but trust me, it does), allowing for good Wayland/X11 interoperablity.