Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sorting since the lods are generated from closest to furthest. #68006

Closed
wants to merge 1 commit into from

Conversation

fire
Copy link
Member

@fire fire commented Oct 29, 2022

  1. Multiple bugs show the wrong lod level. The lods seem to be decimated too quickly
  2. Neither the distance or the index comparator make sense to sort lods.
  3. They're generated from most detail to the least detail already. The only operation I can see is maybe a reverse list and definitely not a sort in any other order.
  4. If this is an optimization it should have no visible lod effect. So the removal is valid because it has an unexpected visual effect.

Discussed with Detox on the discord server.

Fixes: #67891

@fire
Copy link
Member Author

fire commented Oct 29, 2022

@reduz @JFonS does anyone remember the original reason we sort lod levels?

@fire
Copy link
Member Author

fire commented Nov 24, 2022

Discussed that this was the wrong implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visible LOD artifacts in Basketball
3 participants