Fix stretch transform when resizing SubViewports #67331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
force-pushed
the
fix-subviewport-no-stretch-update
branch
3 times, most recently
from
6e068a1 to
3f318b0
Compare
Sauermann
force-pushed
the
fix-subviewport-no-stretch-update
branch
from
3f318b0 to
5d04ea1
Compare
Sauermann
force-pushed
the
fix-subviewport-no-stretch-update
branch
from
5d04ea1 to
8274862
Compare
Sauermann
force-pushed
the
fix-subviewport-no-stretch-update
branch
2 times, most recently
from
fdbdfd3 to
7c477f4
Compare
Move calculation of stretch transform from outside to inside of `Viewport::_set_size` function.
Sauermann
force-pushed
the
fix-subviewport-no-stretch-update
branch
from
7c477f4 to
8182f29
Compare
RandomShaper
approved these changes
Feb 1, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #67329
resolve #68871
In
SubViewport::set_sizethe following function is called:godot/scene/main/viewport.cpp
Line 4112 in 895428c
The problem is, that currently
_stretch_transform()is based on the previous size of theSubViewportinstead of the newp_size.This PR changes the code, so that stretch transform is now calculated inside of
Viewport::_set_size, where the newsizeandsize_2d_overrideare available.Updated 2022-11-19: Fix merge conflict
Updated 2023-01-27: Fix merge conflict
Updated 2023-02-01: Fix merge conflict with #66906