Split script navigation state and edit state #66300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paulb23
requested changes
Sep 25, 2022
KoBeWi
commented
Sep 25, 2022
Comment on lines
-3388
to
+3393
| if (Object::cast_to<ScriptEditorBase>(n)) { | ||
| Object::cast_to<ScriptEditorBase>(n)->set_edit_state(history[history_pos].state); | ||
| Object::cast_to<ScriptEditorBase>(n)->ensure_focus(); | ||
| ScriptEditorBase *seb = Object::cast_to<ScriptEditorBase>(n); | ||
| if (seb) { | ||
| seb->set_edit_state(history[history_pos].state); | ||
| seb->ensure_focus(); | ||
|
|
||
| Ref<Script> script = Object::cast_to<ScriptEditorBase>(n)->get_edited_resource(); | ||
| Ref<Script> script = seb->get_edited_resource(); |
There was a problem hiding this comment.
This is not necessary after removal of set_navigation_state(), but it's probably a nice refactor.
Paulb23
approved these changes
Oct 4, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when you move in script editor history, the editor will store everything, including bookmarks, breakpoints and current highlighter. This actually leads to some bugs, e.g. old bookmarks can be restored if you go back to previous script.
This PR adds a navigation state, which is a subset of script edit state. Script editor history will use it instead.
Helps #63515