Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Remove redundant -fomit-frame-pointer and -ftree-vectorize #66297

Conversation

akien-mga
Copy link
Member

  • -fomit-frame-pointer is included automatically by both GCC and Clang in -O1 and above.
  • -ftree-vectorize is included automatically by GCC in -O2 and beyond, and seems always enabled by Clang.

Closes #66296. See that issue for a detailed investigation.

- `-fomit-frame-pointer` is included automatically by both GCC and
  Clang in `-O1` and above.
- `-ftree-vectorize` is included automatically by GCC in `-O2` and
  beyond, and seems always enabled by Clang.

Closes godotengine#66296. See that issue for a detailed investigation.
@akien-mga akien-mga added enhancement topic:buildsystem cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Sep 23, 2022
@akien-mga akien-mga added this to the 4.0 milestone Sep 23, 2022
@akien-mga akien-mga requested review from a team as code owners September 23, 2022 11:57
@akien-mga akien-mga merged commit 56e847e into godotengine:master Sep 23, 2022
@akien-mga akien-mga deleted the scons-remove-fomit-frame-pointer-ftree-vectorize branch September 23, 2022 13:21
@timothyqiu
Copy link
Member

Cherry-picked for 3.6

@timothyqiu timothyqiu removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review use of -fomit-frame-pointer and -ftree-vectorize flags for optimized builds
2 participants