SCons: Refactor handling of production flag and per-platform LTO defaults
#65745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
topic:buildsystem
regression
cherrypick:3.x
akien-mga
force-pushed
the
scons-production-lto-earlier
branch
from
2d5a991 to
91fd93b
Compare
|
I'll need to dig a bit deeper, I moved the C++ flags before |
…faults Fixup to godotengine#63288. See godotengine#65583 for the bug report. Co-authored-by: Cyberrebell <[email protected]>
akien-mga
force-pushed
the
scons-production-lto-earlier
branch
from
91fd93b to
35a15e6
Compare
akien-mga
changed the title
production flag before configureproduction flag and per-platform LTO defaults
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup to #63288.
Supersedes #65583, see that PR for the bug report.
Co-authored-by: @Cyberrebell