Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of XML CDATA and add test cases #65555

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Fix parsing of XML CDATA and add test cases #65555

merged 1 commit into from
Sep 9, 2022
+165 −1

Conversation

timothyqiu
Copy link
Member

Fixes #65416

This is a regression introduced in #48806. The condition should be negated.

Also added some test cased for XMLParser based on those listed in #48779 (comment) and this issue.

@timothyqiu timothyqiu added this to the 4.0 milestone Sep 9, 2022
@timothyqiu timothyqiu requested review from a team as code owners September 9, 2022 02:25
@timothyqiu timothyqiu mentioned this pull request Sep 9, 2022
Merged
@akien-mga akien-mga merged commit b4967e3 into godotengine:master Sep 9, 2022
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the xml-parser-fixes branch September 9, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

XML Parser does not strip outtag of CDATA
2 participants
@timothyqiu @akien-mga