Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes LOD scaling issues on skinned meshes. #65493

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fixes LOD scaling issues on skinned meshes. #65493

merged 1 commit into from
Sep 14, 2022

Conversation

SaracenOne
Copy link
Member

@SaracenOne SaracenOne commented Sep 7, 2022 •
edited by akien-mga
Loading

Adds a new function to the import pipeline which applies skinning bindposes from the rest to the underlying meshes. Fixes LOD creation issues on meshes where the mesh's size does not match the skinning.

Bugsquad edit:

@SaracenOne SaracenOne added this to the 4.0 milestone Sep 7, 2022
@SaracenOne SaracenOne requested a review from a team as a code owner September 7, 2022 19:17
@Calinou
Copy link
Member

Calinou commented Sep 8, 2022

Does this resolve #57895?

@fire
Copy link
Member

fire commented Sep 8, 2022

This resolves #57895 and others. See #63812

@SaracenOne
Copy link
Member Author

Reduz requested a change of approach in how we fix this, so let me put it on hold for now while I re-evaluate

@SaracenOne SaracenOne marked this pull request as draft September 8, 2022 13:22
@SaracenOne SaracenOne changed the title Apply skin binds on import. Fixes LOD scaling issues. Fixes LOD scaling issues on skinned meshes. Sep 13, 2022
@SaracenOne SaracenOne marked this pull request as ready for review September 13, 2022 21:10
reduz
reduz reviewed Sep 13, 2022
View reviewed changes
editor/import/resource_importer_scene.cpp Outdated Show resolved Hide resolved
editor/import/resource_importer_scene.cpp Outdated Show resolved Hide resolved
editor/import/resource_importer_scene.cpp Outdated Show resolved Hide resolved
@reduz
Copy link
Member

reduz commented Sep 13, 2022

It looks great though!

@SaracenOne SaracenOne force-pushed the lod_scaling branch 2 times, most recently from c1d34fa to 41709d8 Compare September 13, 2022 21:45
@SaracenOne SaracenOne requested a review from a team as a code owner September 13, 2022 21:45
@SaracenOne SaracenOne force-pushed the lod_scaling branch 4 times, most recently from 0446aef to 57ea7bc Compare September 14, 2022 01:07
@akien-mga akien-mga merged commit d9e974c into godotengine:master Sep 14, 2022
@akien-mga
Copy link
Member

Thanks!

@nathanfranke nathanfranke mentioned this pull request Sep 14, 2022
Closed
@fire fire deleted the lod_scaling branch September 16, 2022 20:56
@fire fire mentioned this pull request Sep 23, 2022
Closed
This was referenced Oct 8, 2022
Closed
Closed
@lyuma lyuma mentioned this pull request Oct 22, 2022
Closed
@Zylann Zylann mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reduz reduz reduz approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:import topic:3d
Projects
None yet
Milestone
4.0
5 participants
@SaracenOne @Calinou @fire @reduz @akien-mga