Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @GlobalScope and @GDScript at the bottom of the list #65237

Closed

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Sep 2, 2022

Fix #63799

Shuffles the documentation generation around so that @GlobalScope and script language built-ins are generated before anything else.

Fix godotengine#63799
Shuffles the documentation generation around so that `@GlobalScope` and script language built-ins are  generated before anything else.
@mhilbrunner
Copy link
Member

cc @YuriSizov - looks like a simple change and makes sense, although I wonder if the order of generation should be what decides this at all. Probably? Maybe we could also sort alphabetically, not sure, but us having more control over this may be nice, I guess.

@Mickeon
Copy link
Contributor Author

Mickeon commented Oct 19, 2022

Honestly a personal peeve that I could've also done, in retrospective, is the fact that the function is one giant block instead of being split into multiple helper functions, which makes much more difficult to read.

@YuriSizov
Copy link
Contributor

although I wonder if the order of generation should be what decides this at all.

Indeed, it shouldn't. So as a solution to the problem presented, this is not a proper one. Beyond that I can't say at the moment what it'd affect, as I am not available.

@mhilbrunner
Copy link
Member

PR review meeting: we should just sort the displayed order alphabetically instead, so this no longer depends on the order its generated in

@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Jan 12, 2023
@YuriSizov
Copy link
Contributor

For the record, I'm working on these sorting improvements, but it's not so trivial and there are a few additional changes required to implement it proper, so no PR yet.

@AThousandShips
Copy link
Member

Superseded by:

Thank you nonetheless!

@AThousandShips AThousandShips removed this from the 4.x milestone Feb 6, 2024
@Mickeon
Copy link
Contributor Author

Mickeon commented Feb 6, 2024

I will never financially recover from this burden

@Mickeon Mickeon deleted the fix-global-scope-down-the-list branch February 6, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: @GDScript and @GlobalScope are at the bottom of the list
5 participants